-
-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add server-sent events example #204
Conversation
18d1de4
to
9f2742f
Compare
9f2742f
to
f12d85a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Please
- use
sirv
instead ofserve-static
- use single quotes in the JS instead of doubles
- remove empty newlines in the HTML
sorry for the nits :) looks good
It's all good this is legit, I'm usually using Thanks! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #204 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 104 104
=========================================
Hits 104 104 ☔ View full report in Codecov by Sentry. |
Thanks! |
Hello,
As discussed in #84, I just added an example with Server-Sent Events using polka.
I followed the same pattern as for other examples but let me know if you want me to add anything else.